Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix development setup #456

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix development setup #456

merged 2 commits into from
Jul 26, 2021

Conversation

rabengraph
Copy link
Contributor

No description provided.

@rabengraph rabengraph changed the base branch from master to next July 19, 2021 10:05
@nsams
Copy link
Member

nsams commented Jul 19, 2021

it's still failing, and using npm 7.20

@rabengraph
Copy link
Contributor Author

rabengraph commented Jul 19, 2021 •
edited
Loading

it's still failing, and using npm 7.20

  • lint pipline is fixed

  • local development is fixed

  • deployment on netlify is not yet fixed

@rabengraph rabengraph marked this pull request as draft July 19, 2021 13:05
@rabengraph
Copy link
Contributor Author

The behaviour has been bug-reported on npm/cli#3553.

@vivid-planet-bot vivid-planet-bot marked this pull request as ready for review July 20, 2021 12:08
@rabengraph rabengraph requested a review from kaufmo July 20, 2021 12:30
@manuelblum manuelblum self-requested a review July 21, 2021 08:17
@manuelblum manuelblum mentioned this pull request Jul 21, 2021
Closed
@rabengraph rabengraph merged commit d266430 into next Jul 26, 2021
@rabengraph rabengraph deleted the fix-development-setup branch July 26, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsams nsams nsams approved these changes

@manuelblum manuelblum manuelblum approved these changes

@kaufmo kaufmo Awaiting requested review from kaufmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabengraph @nsams @manuelblum