Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning message on LLaMA FastTokenizer #1037

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

WoosukKwon
Copy link
Collaborator

The warning message is for the LLaMA V1 model, and does not hold for all LLaMA variants. The PR clarifies that it is for LLaMA V1.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@zhuohan123 zhuohan123 merged commit 64ca424 into main Sep 15, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the llama-tokenizer-warning branch September 15, 2023 02:09
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants