Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyarrow to dependencies & Print warning on Ray import error #1094

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

WoosukKwon
Copy link
Collaborator

Thanks @infwinston for reporting the error!

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@WoosukKwon
Copy link
Collaborator Author

Let's have this quick fix first and then remove the dependencies afterwards.

@WoosukKwon WoosukKwon merged commit 400b828 into main Sep 19, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the warn-ray-import-error branch September 19, 2023 05:36
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants