Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --ipc=host in docker run for distributed inference #1125

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

WoosukKwon
Copy link
Collaborator

When the shared memory allocated for a docker container is too small and when TP is used, vLLM can hang or perform bad. While users can manually increase shm-size, --ipc=host can be a simple solution to this.

Reference: pytorch/pytorch#1158 (comment)

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@WoosukKwon WoosukKwon merged commit 7d7e3b7 into main Sep 22, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the dist-docs branch September 22, 2023 01:26
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants