Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance figures for dark mode #160

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Add performance figures for dark mode #160

merged 3 commits into from
Jun 19, 2023

Conversation

WoosukKwon
Copy link
Collaborator

No description provided.

@WoosukKwon WoosukKwon changed the title Add dark figures Add performance figures for dark mode Jun 19, 2023
@WoosukKwon
Copy link
Collaborator Author

@zhuohan123 Currently, the images have white/black background. Do you want to make the background of these images transparent?

@zhuohan123
Copy link
Member

Please make them transparent, especially for the dark mode, since the background of dark mode is not actually black, it's some kind of gray.

@WoosukKwon
Copy link
Collaborator Author

@zhuohan123 I see. I made them all transparent. PTAL.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this and fix the README in another PR.

@WoosukKwon WoosukKwon merged commit 5822ede into main Jun 19, 2023
@WoosukKwon WoosukKwon deleted the dark-figs branch June 19, 2023 06:46
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
yukavio pushed a commit to yukavio/vllm that referenced this pull request Jul 3, 2024
SUMMARY:
* add missing "__init__.py"
* disambiguate artifact name collision
* adjust timeouts

TEST PLAN:
runs on remote push

Co-authored-by: andy-neuma <andy@neuralmagic.com>
Xaenalt pushed a commit to Xaenalt/vllm that referenced this pull request Aug 15, 2024
Xaenalt pushed a commit to Xaenalt/vllm that referenced this pull request Aug 15, 2024
dtrifiro pushed a commit to dtrifiro/vllm that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants