Raise error for long prompt #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Lily, please check all the possible situations here and make sure you can handle all of them. Thanks! |
|
I move forward with the length check. The original code should already handle the |
zhuohan123
requested changes
Jun 30, 2023
Closed
zhuohan123
approved these changes
Jul 1, 2023
michaelfeil
pushed a commit
to michaelfeil/vllm
that referenced
this pull request
Jul 1, 2023
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
sjchoi1
pushed a commit
to casys-kaist-internal/vllm
that referenced
this pull request
May 7, 2024
yukavio
pushed a commit
to yukavio/vllm
that referenced
this pull request
Jul 3, 2024
…project#273) SUMMARY: * update benchmarking, testing, and accuracy jobs to run on label `aws-test-a10g-24G` or `aws-test-a10-96G` which is based on "vanilla deeplearning" AMI * update relevant GHA actions and workflows to not be dependent on `pyenv` virtualenv * update "model cache" to use local disk as opposed to "EFS" TEST PLAN: runs on remote push --------- Co-authored-by: andy-neuma <andy@neuralmagic.com> Co-authored-by: Domenic Barbuzzi <domenic@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #113. The program hangs when the input prompt is too long because the check will always succeed and the request will always in the waiting queue and will never be added to the running queue.
Add a check before the if statement, if the prompt length is too long, it will raise ValueError directly.