Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Bump fastapi and pydantic version #8435

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

DarkLight1337
Copy link
Member

FIX #8212

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 13, 2024
@simon-mo simon-mo enabled auto-merge (squash) September 13, 2024 01:09
@simon-mo simon-mo merged commit 3f79bc3 into vllm-project:main Sep 13, 2024
70 checks passed
@DarkLight1337 DarkLight1337 deleted the bump-openai-version branch September 13, 2024 03:23
Jeffwan pushed a commit to aibrix/vllm that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FastAPI 0.113.0 breaks vLLM OpenAPI
3 participants