Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Extend test GenerateName support to Unstructureds #420

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Extend test GenerateName support to Unstructureds #420

merged 1 commit into from
Aug 31, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Aug 30, 2023

Unstructured resources do not implement ObjectMetaAccessor, we should cast the object to metav1.Object instead.

Unstructured resources do not implement ObjectMetaAccessor, we should
cast the object to metav1.Object instead.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% 🎉

Comparison is base (5be8c31) 60.62% compared to head (b3065a7) 60.73%.

❗ Current head b3065a7 differs from pull request most recent head 2c1bed2. Consider uploading reports for the commit 2c1bed2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   60.62%   60.73%   +0.11%     
==========================================
  Files          24       24              
  Lines        2334     2333       -1     
==========================================
+ Hits         1415     1417       +2     
+ Misses        835      833       -2     
+ Partials       84       83       -1     
Files Changed Coverage Δ
testing/client.go 55.12% <100.00%> (+1.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@garethjevans garethjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this resolves my test issues, thanks

@scothis scothis merged commit 5ee2ecc into vmware-labs:main Aug 31, 2023
1 check passed
@scothis scothis deleted the generate-name-unstructured branch August 31, 2023 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants