Skip to content
This repository has been archived by the owner on Aug 28, 2024. It is now read-only.

Allow access to known children in ChildSetReconciler#DesiredChildren #458

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Allow access to known children in ChildSetReconciler#DesiredChildren #458

merged 1 commit into from
Nov 21, 2023

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Nov 9, 2023

Current known children can be obtained via RetrieveKnownChildren(ctx). This can be used to keep existing children while stamping out new resources, or for garbage collecting resources based on some criteria. Return the children that should be kept and omit children to delete.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e002cf4) 60.54% compared to head (a8abd38) 60.67%.

Files Patch % Lines
reconcilers/childset.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   60.54%   60.67%   +0.13%     
==========================================
  Files          26       26              
  Lines        2532     2543      +11     
==========================================
+ Hits         1533     1543      +10     
- Misses        910      911       +1     
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@squeedee squeedee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Current known children can be obtained via
RetrieveKnownChildren[ChildType](ctx). This can be used to keep existing
children while stamping out new resources, or for garbage collecting
resources based on some criteria. Return the children that should be
kept and omit children to delete.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis merged commit e22ffba into vmware-labs:main Nov 21, 2023
3 checks passed
@scothis scothis deleted the known-children branch November 21, 2023 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants