Handle pointer items in ObjectList with ChildReconciler

[scothis]

Canonically, Items in an ObjectList are a slice of structs. Some types, like Istio, use a slice of pointers intead. We now detect and handle both.

Resolves #479

[vmwclabot]

@scothis, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e22ffba) 60.67% compared to head (23afd45) 61.02%.
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
+ Coverage   60.67%   61.02%   +0.34%     
==========================================
  Files          26       27       +1     
  Lines        2543     2581      +38     
==========================================
+ Hits         1543     1575      +32     
- Misses        911      917       +6     
  Partials       89       89              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vmwclabot]

@scothis, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[scothis]

@neowulf can you give this branch a try?

[mamachanko]

@neowulf can you give this branch a try?

Because personally I can never recall the correct incantation, this may help:

go mod edit -replace github.com/vmware-labs/reconciler-runtime=github.com/scothis/reconciler-runtime@object-list-pointer
go mod tidy

[neowulf]

Thank you for the quick response! Yes, this patch works!

[vmwclabot]

@scothis, VMware has approved your signed contributor license agreement.