chore: upgrade carvel-imgpkg #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashwathi
approved these changes
May 31, 2022
odinnordico
force-pushed
the
upgrade-carvel-imgpkg
branch
from
56dee5b
to
263a6aa
Compare
shashwathi
reviewed
Jun 1, 2022
pkg/source/imgpkg.go
Outdated
| // users can set this env var to true to let imgpkg find creds based on the IaaS provider | ||
| // for CLI we are setting the default to false | ||
|
|
||
| envVars := []string{"IMGPKG_ENABLE_IAAS_AUTH=false"} |
There was a problem hiding this comment.
This needs doc update because this is introducing new feature, if its just deps update then remove this part
odinnordico
force-pushed
the
upgrade-carvel-imgpkg
branch
from
263a6aa
to
b651b06
Compare
scothis
reviewed
Jun 3, 2022
Co-authored-by: Wendy Maria Arango Chavarria <warango@vmware.com> Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
odinnordico
force-pushed
the
upgrade-carvel-imgpkg
branch
from
b651b06
to
9114684
Compare
scothis
suggested changes
Jun 6, 2022
| envVars := os.Environ() | ||
| _, present := os.LookupEnv("IMGPKG_ENABLE_IAAS_AUTH") | ||
| if !present { | ||
| envVars = append(envVars, "IMGPKG_ENABLE_IAAS_AUTH=false") |
There was a problem hiding this comment.
question Are you sure you want to change the imgpkg defaults? Many people expect the credential helpers to work by default. Minimally, this change should be called out on the PR.
There was a problem hiding this comment.
@odinnordico : I removed this env var section and built it locally. CLI commands for local path flow works. I am able to verify the images on the registry.
Co-authored-by: Wendy Maria Arango Chavarria <warango@vmware.com> Signed-off-by: Diego Alfonso <dalfonso@vmware.com>
odinnordico
force-pushed
the
upgrade-carvel-imgpkg
branch
from
2ade50b
to
8ccdcba
Compare
|
New PR will be open with different approach based in carvel-imgpkg issue 397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Upgrade imgpkg to latest version (v0.29.0)
Which issue(s) this PR fixes
Fixes #127
Describe testing done for PR
testing in local sandbox with MacOS Monterey and Windows 11.
Windows 11
Monterey
Additional information or special notes for your reviewer