Only release semver tags #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to create multiple tags for the same commit so that go can resolve the webhook module. We don't need to run CI on those tags. Otherwise we'll get an error from the release script like https://github.com/vmware-tanzu/cartographer-conventions/runs/5684344434?check_suite_focus=true Signed-off-by: Scott Andrews <andrewssc@vmware.com>
|
tested with a smattering of tags against my fork. These ran CI:
These did not run CI:
|
rszumlakowski
requested changes
Mar 30, 2022
.github/workflows/ci.yaml
Outdated
| @@ -6,7 +6,8 @@ on: | |||
| - 'main' | |||
| - '!dependabot/**' | |||
| tags: | |||
| - '**' | |||
| # semver tags | |||
| - 'v[0-9]+.[0-9]+.[0-9]+-?**' | |||
There was a problem hiding this comment.
Period characters in a regular expression can match any character. You should prefix these periods with a backslash (i.e.: \.) to indicate that you really do want periods to separate the components in the semver string.
There was a problem hiding this comment.
good catch, updated
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage ? 70.18%
=======================================
Files ? 17
Lines ? 909
Branches ? 0
=======================================
Hits ? 638
Misses ? 251
Partials ? 20 Continue to review full report at Codecov.
|
rszumlakowski
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to create multiple tags for the same commit so that go can
resolve the webhook module. We don't need to run CI on those tags.
Otherwise we'll get an error from the release script like
https://github.com/vmware-tanzu/cartographer-conventions/runs/5684344434?check_suite_focus=true
Signed-off-by: Scott Andrews andrewssc@vmware.com