Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables Go linter for the repo #175

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

srm09
Copy link
Contributor

@srm09 srm09 commented Sep 11, 2020

No description provided.

@srm09 srm09 marked this pull request as ready for review September 11, 2020 21:20
@srm09 srm09 force-pushed the enahnce-github-actions branch 3 times, most recently from 8982018 to 45a9af2 Compare September 11, 2020 22:51
@srm09 srm09 changed the title Enahnce GitHub actions Enables Go linter for the repo Sep 11, 2020
Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes.

.github/workflows/compile-test.yaml Outdated Show resolved Hide resolved
k8s/search_result.go Outdated Show resolved Hide resolved
This patch enables a new Github Action which does static code anaylsis
and a format check for each push and pull request. It also removes all
the existing linter errors in the codebase

Signed-off-by: Sagar Muchhal <muchhals@vmware.com>
rnd = rand.New(rand.NewSource(time.Now().Unix()))
sshContainerName = "test-sshd"
sshPort = NextPortValue()
InfraSetupWait = time.Second * 11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that name!!

Copy link
Contributor

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srm09 srm09 merged commit 3174cdc into vmware-tanzu:main Sep 17, 2020
@srm09 srm09 deleted the enahnce-github-actions branch September 17, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants