-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease updates #5123
Prerelease updates #5123
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
@@ -12,5 +12,5 @@ COPY . /app | |||
RUN yarn run prettier-check && yarn run ts-compile-check | |||
RUN yarn run build | |||
|
|||
FROM bitnami/nginx:1.22.0-debian-11-r3 | |||
FROM bitnami/nginx:1.23.1-debian-11-r1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that the update to the branch 1.23.x is also going to be carried out by the Bitnami team near soon.
I haven't pushed any CI image as I'd rather wait for #5083 to be merged. |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
I've been looking into upgrading also the Helm version to 3.9.X (as required by #4216, eventually). In this version, they have also bumped the k8s versions up. As long as we also update our k8s dependencies we should be fine... well, we're not: Currently, our code is not compatible with k8s >=1.24 (including upgrading the submodule) due to the following deprecations:
In short, even if we perform the change on the Flux queue, we would still be blocked by the kapp dependency; in particular, this line. If we manually update client-go in our code, we will get several compilation errors due to a dependency rename from So, in short, as of today, we cannot update to Helm 3.9.X nor k8s >= 1.24 unless kapp is using a |
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/package.json
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
I can take care of ShutDownWithDrain in the next PR |
Unfortunately, this function is not yet available in the workqueue interface on client-go v0.22.x, as it was introduced in v0.23. That said, I don't see any problem with implementing this additional function now, this way we will have done that change once we bump it up from 0.22.x, so thanks for taking care of it! |
No problem. Will take care of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Kapp has just released a new version, https://github.com/vmware-tanzu/carvel-kapp/releases/tag/v0.52.0, updating the k8s deps! |
Description of the change
This PR is just performing the usual update on our dependencies as described in our release process.
Benefits
Up-to-date deps
Possible drawbacks
Perhaps an incompatibility? Let's our CI bespeak.
Applicable issues
Additional information
N/A