Add --validate flag to builder inventory plugin add command to validate plugin exists or not
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujc25
force-pushed
the
add-validate-override-plugin-publish
branch
from
057fa7c
to
0d44fb5
Compare
anujc25
changed the title
--validate flag to builder inventory plugin insert command to validate plugin exists or not--validate flag to builder inventory plugin add command to validate plugin exists or not
marckhouzam
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
I think this is sufficient for now since I believe this --validate flag will be used in automation and not by humans. If we want to support this for humans at a later time, it is just the error output that I don't like too much, as it says that it couldn't insert the plugins although we are just doing validation.
But like I said, this is not important for automation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
--validateflag to thebuilder inventory plugin addcommand to validate the plugin already exists or not in the plugin inventory database.Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer