Add CEIP Opt-In support #143
Conversation
prkalle
force-pushed
the
feature/ceip-opt
branch
from
6b73954
to
e326bcc
Compare
prkalle
force-pushed
the
feature/ceip-opt
branch
2 times, most recently
from
eabcf4a
to
5fd8cfe
Compare
prkalle
force-pushed
the
feature/ceip-opt
branch
from
5fd8cfe
to
7d5b12c
Compare
prkalle
force-pushed
the
feature/ceip-opt
branch
from
7d5b12c
to
4048625
Compare
There was a problem hiding this comment.
Thanks @prkalle. I noticed the commit message mentions the wrong environment variable.
prkalle
force-pushed
the
feature/ceip-opt
branch
2 times, most recently
from
23b73d0
to
a9fb1a8
Compare
Thanks @marckhouzam . Upated the commit message. |
There was a problem hiding this comment.
Shoot, this can break shell completion.
$ rm ~/.config/tanzu/config*
$ tz [tab][tab]
^[7^[[1A^[[0G^[[1A^[[0G^[8^[[?25h
^[7^[[?25l^[8^[[0G^[[2K^[[1;36m? ^[[0m^[[1;99m
^[[0m ^[[36m[Use arrows to move, type to filter]^[[0m
^[[1;36m> Yes^[[0m
^[[39m No^[[0m
Do you agree to Participate in the Customer Experience Improvement Program?
For more details about the Program, please see http://www.vmware.com/trustvmware/ceip.html
VMware's Customer Experience Improvement Program ("CEIP") provides VMware with information that enables VMware to improve its products and services and fix problems. By choosing to participate in CEIP, you agree that VMware may collect technical information about your use of VMware products and services on a regular basis. This information does not personally identify you.
It will also have an impact on OS packages that setup shell completion before the user ever uses tanzu. Also, if a user adds source <(tanzu completion bash) to their .bashrc file and at one point removes the config file, it will break their shell startup.
I suggest we disable this prompt for the completion and __complete commands.
- User would be prompted for CEIP Opt-In on any first tanzu command. Users choice would be persisted in the tanzu configuration file. Users can skip the prompt by providing their choice(yes/no) using the environment variable (TANZU_CLI_CEIP_OPT_IN_PROMPT_ANSWER) on the first use - Also added commands(experimental) "tanzu ceip-participation set" and "tanzu ceip-participation get" to get and set the CEIP Opt-In status Signed-off-by: Prem Kumar Kalle <pkalle@vmware.com>
prkalle
force-pushed
the
feature/ceip-opt
branch
from
a9fb1a8
to
e58239b
Compare
@marckhouzam thanks for pointing out. Updated the PR as you suggested. |
What this PR does / why we need it
This PR adds support for CEIP(Customer Experience Improvement Program) Opt-In support.
Summary of changes:
tanzu telemetrypluginWhich issue(s) this PR fixes
Fixes #142
Describe testing done for PR
User would be prompted for CEIP opt-in choice on the first use( any tanzu command/plugin comamnd) as shown below.
Based on the users selection, the status would be persisted in tanzu
config-ng.yamlconfiguration file and user wouid not be prompted on subsequent tanzu command executions.User can also skip the prompt by setting the environment variable
TANZU_CLI_CEIP_OPT_IN_PROMPT_ANSWERtoYesorNoUser can get their current CEIP participation status using
tanzu ceip-participation getcommandUser can update their current CEIP participation status using
tanzu ceip-participation setcommandRelease note
Additional information
Special notes for your reviewer
This PR is depending on
tanzu-plugin-runtimePR:42. So build and CI jobs would fails. I will update the PR with tanzu-plugin-runtime dependency in go.mod dependency once the other PR is merged. However the PR is open for comments and PR.