Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the tanzu installation locations #173

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Apr 4, 2023

What this PR does / why we need it

Unifying the installation of Tanzu
The names of the directories for the plugins, catalog cache and local
plugin discovery (<XDG_DATA_HOME>/_tanzu-cli, $HOME/.cache/_tanzu, $HOME/.config/_tanzu-plugins) are all directories prefixed with " _ " previously , so as not to conflict with their nonprefixed counterparts is changed to use the existing CLI installations directories without ' _' prefix

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

As part of testing #124

  • Added cli coexistence go tests using e2e framework.
  • Added GitHub workflow to run CLI-Coexistence Tests using docker

Tested the unification and coexistence by writing test using E2E framework for various use cases involving installing plugins, Core CLI commands config set,get,context.

Manual testing in a docker environment to verify the unification and coexistence of new Tanzu CLI and legacy Tanzu CLI- v0.28 are performed.

Release note

Tanzu Installation locations uses the existing CLI installations directories without ' _' prefix 

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya requested a review from a team as a code owner April 4, 2023 21:13
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@vuil vuil merged commit b80820e into vmware-tanzu:main Apr 4, 2023
@vuil vuil added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process label Apr 7, 2023
@mpanchajanya mpanchajanya deleted the unify_tanzu_locations branch September 25, 2023 19:56
@marckhouzam marckhouzam added this to the v0.90.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required kind/cleanup Categorizes issue or PR as related to cleaning up code, process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants