-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: plugin sync e2e test implementation for TMC target #229
E2E: plugin sync e2e test implementation for TMC target #229
Conversation
4a79f01
to
25c9317
Compare
31144e2
to
c20b48b
Compare
e7a5c62
to
543188d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @chandrareddyp. I have added a few minor comments but overall looks good.
We should add a TMC test case where the endpoint gets updated to return additional plugins, and CLI should be able to sync the newer plugins with tanzu plugin sync
.
1b031bf
to
fc1591e
Compare
Added "Use Case 5: Update the TMC endpoint with additional plugins, and ensure that the plugin sync updates the latest additional plugins." |
81060a7
to
4cef2fd
Compare
db1ab9e
to
19b98d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is great. Thanks for adding these important tests.
…u#229) Co-authored-by: Chandra Pamuluri <cpamuluri@cpamuluri-a01.vmware.com>
What this PR does / why we need it
This PR has E2E test cases and tooling implementations for TMC specific use cases. It uses
rodolpheche/wiremock
HTTP mock server to mock TMC HTTP calls. CLI Core code has been updated to skip HTTPS hard coding when the environment variableTANZU_CLI_E2E_TEST_ENVIRONMENT
is set to true, since CLI Core supports only HTTPS calls with well know CA, we have created a story to support HTTPS with self-signed certificates.To run these tests locally, you need to set the
TANZU_API_TOKEN
with TMC API token, then call the targetmake e2e-plugin-sync-tmc
Which issue(s) this PR fixes
Fixes # NA
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer