Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR Keyless access - deps bumped and changed to k8schain #102

Merged
merged 1 commit into from
May 26, 2023

Conversation

rashedkvm
Copy link
Member

Pull request

What this PR does / why we need it

Tanzu Source Controller on EKS with ECR as a registry and auth against ECR via IAM role, the request fails.

Which issue(s) this PR fixes

Fixes #77

Describe testing done for PR

Manual testing on an EKS cluster with ECR

k get imagerepositories.source.apps.tanzu.vmware.com -A
NAMESPACE   NAME                      IMAGE                                                                                                   URL                                                                                                                                                                                                          READY   REASON   AGE
default     imagerepository-dkrhb     XXXXXXXX/tanzu-hava-app-image@sha256:185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f   http://source-controller-manager-artifact-service.source-system.svc.cluster.local./imagerepository/default/imagerepository-dkrhb/185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f.tar.gz     True    Ready    17m
default     imagerepository-no-auth   XXXXXXXXXX.dkr.ecr.us-east-2.amazonaws.com/tsc-test-repo:dev                                            http://source-controller-manager-artifact-service.source-system.svc.cluster.local./imagerepository/default/imagerepository-no-auth/185ec690a4fa84328ac97b6fe021974c9313859a9a87f3b8a2b8131982544e8f.tar.gz   True    Ready    17m

Additional information or special notes for your reviewer

Signed-off-by: Rashed Kamal <krashed@vmware.com>
@rashedkvm rashedkvm merged commit f559714 into vmware-tanzu:main May 26, 2023
@rashedkvm rashedkvm deleted the ecr-eks branch May 26, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR Keyless login fails
3 participants