Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the documents with taint as pre-requisite #140

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

ridaz-zz
Copy link
Contributor

@ridaz-zz ridaz-zz commented Jan 6, 2022

What type of PR is this?
/kind bug fix

What this PR does / why we need it:
This PR will bring in the following changes :

  1. Set the CPIStatus Phase as Deployed/Configuring when CPI is not assigned with Provider ID
  2. In order to bring up CPI and some versions of CSI successfully, the nodes need to be tainted with
    node.cloudprovider.kubernetes.io/uninitialized=true:NoSchedule

Which issue(s) this PR fixes:

Fixes #141

Test Report Added?:

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind TESTED

Test Report:

1. When CPI is configured successfully

kubectl get pods -A
NAMESPACE           NAME                                      READY   STATUS    RESTARTS   AGE
vmware-system-vdo   vdo-controller-manager-74455b7d4d-mtfgp   2/2     Running   0          44s
vdoctl configure drivers
VDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaultVDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaultVDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaultVDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaults for compatiblity matrix (Y/N) ?  Y
Do you want to configure CloudProvider? (Y/N) Y
Please provide the vcenter IP/FQDN for configuring CloudProvider 
VC IP/ FQDN 10.78.85.172
Do you want to establish a secure connection? (Y/N) N
Please provide the credentials for configuring CloudProvider
Username administrator@vsphere.local
Password ********
Datacenter(s) WCP-DC
Do you want to configure another vcenter for CloudProvider? (Y/N) N
Do you want to configure zones/regions for CloudProvider? (Y/N) N
You have now completed configuration of CloudProvider. We will now proceed to configure StorageProvider.
Please provide the credentials for configuring StorageProvider
Username administrator@vsphere.local
Password ********
Datacenter(s) WCP-DC
Do you wish to provide custom kubelet Path? (Y/N) N
Do you wish to configure File Volumes? (Y/N) N
Thanks for configuring VDO. The drivers will now be installed.
You can check the status for drivers using `vdoctl status`
vdoctl status
CloudProvider   : Configured
	 vCenter : 
		10.78.85.172  (Credentials Verified)
	 Nodes : 
		 worker-vm-7 : ready 
		 master-vm-7 : ready 
StorageProvider : Deployed
	 vCenter : 
		10.78.85.172  (Credentials Verified)
kubectl get pods -A
NAMESPACE           NAME                                      READY   STATUS    RESTARTS   AGE

kube-system         vsphere-cloud-controller-manager-55krr    1/1     Running   0          94s
vmware-system-csi   vsphere-csi-controller-8489c5b7f8-lb65q   6/6     Running   0          86s
vmware-system-csi   vsphere-csi-node-bdgxl                    3/3     Running   0          86s
vmware-system-csi   vsphere-csi-node-wdpjn                    3/3     Running   0          86s
vdoctl version
kubernetes Version : 1.21
VDO Version        : b3e9eba
vSphere Versions   : [7.0.3]
CSI Version        : 2.3.0
CPI Version        : 1.21.0

2. When ProviderID is not assigned

kubectl get pods -A
NAMESPACE           NAME                                     READY   STATUS    RESTARTS   AGE
vmware-system-vdo   vdo-controller-manager-c84bcc8f5-7mqj7   2/2     Running   0          27s
vdoctl configure drivers
VDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaults for compatiblity matrix (Y/N)VDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaults for compatiblity matrix (Y/N)VDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaults for compatiblity matrix (Y/N)VDO is configured with default compatiblity matrix. you can update compatiblity-matrix using 'vdoctl update compatiblity-matrix'. Do you want to use the defaults for compatiblity matrix (Y/N) ?  Y
Do you want to configure CloudProvider? (Y/N) Y
Please provide the vcenter IP/FQDN for configuring CloudProvider 
VC IP/ FQDN 10.78.85.172
Do you want to establish a secure connection? (Y/N) N
Do you want to establish a secure connection? (Y/N) N
Please provide the credentials for configuring CloudProvider
Username administrator@vsphere.local
Password ********
Datacenter(s) WCP-DC
Do you want to configure another vcenter for CloudProvider? (Y/N) N
Do you want to configure zones/regions for CloudProvider? (Y/N) N
You have now completed configuration of CloudProvider. We will now proceed to configure StorageProvider.
Please provide the credentials for configuring StorageProvider
Username administrator@vsphere.local
Password ********
Datacenter(s) WCP-DC
Do you wish to provide custom kubelet Path? (Y/N) N
Do you wish to configure File Volumes? (Y/N) N
Thanks for configuring VDO. The drivers will now be installed.
You can check the status for drivers using `vdoctl status`

vdoctl status
CloudProvider   : Deployed
	 vCenter : 
		10.78.85.172  (Credentials Verified)

StorageProvider : Deployed
	 vCenter : 
		10.78.85.172  (Credentials Verified)
kubectl get pods -A
NAMESPACE           NAME                                      READY   STATUS    RESTARTS   AGE

kube-system         vsphere-cloud-controller-manager-4jdgw    1/1     Running   0          19s
vmware-system-csi   vsphere-csi-controller-8489c5b7f8-9mfxn   6/6     Running   0          16s
vmware-system-csi   vsphere-csi-node-8v9xl                    3/3     Running   0          16s
vmware-system-csi   vsphere-csi-node-rs6mg                    3/3     Running   0          16s
vmware-system-vdo   vdo-controller-manager-c84bcc8f5-7mqj7    2/2     Running   0          2m5s

@ridaz-zz ridaz-zz added the documentation Improvements or additions to documentation label Jan 6, 2022
@ridaz-zz ridaz-zz self-assigned this Jan 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #140 (216beb9) into main (b3e9eba) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   52.12%   52.37%   +0.25%     
==========================================
  Files           6        6              
  Lines        1508     1516       +8     
==========================================
+ Hits          786      794       +8     
  Misses        623      623              
  Partials       99       99              
Flag Coverage Δ
unittests 52.37% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/vdoconfig_controller.go 47.73% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e9eba...216beb9. Read the comment docs.

Copy link
Contributor

@aggarwalta aggarwalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@asifdxtreme asifdxtreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

controllers/vdoconfig_controller.go Outdated Show resolved Hide resolved
@jvrahav jvrahav merged commit 5bf9500 into vmware-tanzu:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPIStatus Phase shows Configured even when ProviderId is not assigned
7 participants