Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo issues and updated the module #158

Merged
merged 1 commit into from
Nov 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/vdoconfig_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ func (r *VDOConfigReconciler) deleteCPIDeployment(ctx vdocontext.VDOContext) (bo
for _, deploymentYaml := range r.CpiDeploymentYamls {
updateStatus, err := r.applyYaml(deploymentYaml, ctx, updateStatus, dynclient.DELETE)
if err != nil {
ctx.Logger.V(4).Info("Error occured when deleting the deployment for CPI : ", deploymentYaml, updateStatus)
ctx.Logger.V(4).Info("Error occurred when deleting the deployment for CPI : ", deploymentYaml, updateStatus)
}
}
return updateStatus, nil
Expand All @@ -740,7 +740,7 @@ func (r *VDOConfigReconciler) deleteCSIDeployment(ctx vdocontext.VDOContext) (bo
for _, deploymentYaml := range r.CsiDeploymentYamls {
updateStatus, err := r.applyYaml(deploymentYaml, ctx, updateStatus, dynclient.DELETE)
if err != nil {
ctx.Logger.V(4).Info("Error occured when deleting the deployment for CSI : ", deploymentYaml, updateStatus)
ctx.Logger.V(4).Info("Error occurred when deleting the deployment for CSI : ", deploymentYaml, updateStatus)
}
}
return updateStatus, nil
Expand Down
2 changes: 1 addition & 1 deletion controllers/vdoconfig_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1458,7 +1458,7 @@ var _ = Describe("TestReconcile", func() {
s.AddKnownTypes(v1alpha1.GroupVersion, &v1alpha1.VDOConfigList{})
s.AddKnownTypes(v1alpha1.GroupVersion, &v1alpha1.VsphereCloudConfig{})

It("should fail loading compatiblity matrix", func() {
It("should fail loading compatibility matrix", func() {
r := VDOConfigReconciler{
Client: fake2.NewClientBuilder().WithRuntimeObjects().Build(),
Logger: ctrllog.Log.WithName("VDOConfigControllerTest"),
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/vmware-tanzu/vsphere-kubernetes-drivers-operator
module github.com/vmware-tanzu/vsphere-kubernetes-drivers-operator/0.3.0

go 1.16

Expand Down
2 changes: 1 addition & 1 deletion pkg/client/dynamic_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func GenerateYamlFromUrl(url string) ([]byte, error) {
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK {
return nil, errors.Errorf("Recieved response code %d reading from url %s", resp.StatusCode, url)
return nil, errors.Errorf("Received response code %d reading from url %s", resp.StatusCode, url)
}

bodyBytes, err := ioutil.ReadAll(resp.Body)
Expand Down
2 changes: 1 addition & 1 deletion pkg/models/modelsutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ package models

// VersionRange defines the min and max version
type VersionRange struct {
// Min defines the minumum required version
// Min defines the minimum required version
Min string `json:"min"`
// Max defines the maximum required version
Max string `json:"max"`
Expand Down