Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and deprecated api's #159

Merged
merged 5 commits into from
Nov 25, 2022
Merged

Update dependencies and deprecated api's #159

merged 5 commits into from
Nov 25, 2022

Conversation

asifdxtreme
Copy link
Collaborator

@asifdxtreme asifdxtreme commented Nov 24, 2022 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR does the following thing

  • Update the Golang version
  • Update the controller-gen version
  • Update the golangci-lint version
  • Update the usage of deprecated api (io/ioutil)
  • go fmt code
  • Update the crd options for new controller-gen
  • Update go version in container for vdo

@asifdxtreme asifdxtreme requested review from jvrahav, aggarwalta, lgayatri and ridaz-zz and removed request for jvrahav November 24, 2022 19:27
@asifdxtreme asifdxtreme self-assigned this Nov 24, 2022
@ridaz ridaz self-requested a review November 25, 2022 04:31
ridaz
ridaz approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@ridaz ridaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@asifdxtreme asifdxtreme merged commit bd2cde7 into main Nov 25, 2022
@asifdxtreme asifdxtreme deleted the greenline branch November 25, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrahav jvrahav jvrahav approved these changes

@aggarwalta aggarwalta Awaiting requested review from aggarwalta

@lgayatri lgayatri Awaiting requested review from lgayatri

@ridaz-zz ridaz-zz Awaiting requested review from ridaz-zz

@corrieb corrieb Awaiting requested review from corrieb

@ridaz ridaz Awaiting requested review from ridaz

Assignees

@asifdxtreme asifdxtreme

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asifdxtreme @jvrahav @ridaz @vmwclabot