Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify update_cbt function and remove --rm flag to support k8s 1.25.7 #37

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Modify update_cbt function and remove --rm flag to support k8s 1.25.7 #37

merged 1 commit into from
Jun 12, 2023

Conversation

ridaz
Copy link
Contributor

@ridaz ridaz commented Jun 6, 2023 •
edited
Loading

This PR will bring in the following changes:

  1. Modify update_cbt function to add a check before updating secretRef in ClusterBootstrapTemplate Config.
  2. Remove the --rm flag from ctr functions , since --rm and --d flag cannot be used together for container version v1.16.8 and above.

Closes issue #36

Testing Done:

  1. Updated the artifacts bundle for 1.25.7
  2. Validated creation of 1.25.7 OVA and creation of TKC
  3. Validated the existing workflow for 1.24.9 OVA and creation of TKC out of it

Signed-off-by: Rida Zuber ridaz@vmware.com

@ridaz
Update update_cbt function and remove --rm flag
605b104 
Signed-off-by: Rida Zuber <ridaz@vmware.com>
@ridaz ridaz changed the title Update update_cbt function and remove --rm flag to support k8s 1.25.7 Modify update_cbt function and remove --rm flag to support k8s 1.25.7 Jun 6, 2023
@DimpleRajaVamsi DimpleRajaVamsi linked an issue Jun 7, 2023 that may be closed by this pull request
Fix the logic for updating the secretRef using update_cbt function's log in tkg_byoi.py and remove the --rm flag in docker start command #36
Closed
DimpleRajaVamsi
DimpleRajaVamsi approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@DimpleRajaVamsi DimpleRajaVamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ridaz ridaz closed this Jun 8, 2023
@ridaz ridaz deleted the topic/ridaz/update-cbt-rm-flag branch June 8, 2023 04:42
@ridaz ridaz restored the topic/ridaz/update-cbt-rm-flag branch June 11, 2023 08:46
@ridaz ridaz reopened this Jun 11, 2023
@DimpleRajaVamsi DimpleRajaVamsi merged commit 9bf40ac into vmware-tanzu:main Jun 12, 2023
@ridaz ridaz deleted the topic/ridaz/update-cbt-rm-flag branch June 12, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrahav jvrahav jvrahav left review comments

@DimpleRajaVamsi DimpleRajaVamsi DimpleRajaVamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ridaz @DimpleRajaVamsi @jvrahav