sql: bump H2 and JOOQ to latest versions and address array syntax change #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
mihaibudiu
suggested changes
Jan 25, 2022
| @@ -64,7 +64,9 @@ protected String visitCreateTable(final CreateTable node, final String sql) { | |||
| final Pattern arrayType = Pattern.compile("ARRAY\\((.+)\\)"); | |||
| Matcher m = arrayType.matcher(h2Type); | |||
| if (m.find()) { | |||
| h2Type = "array"; | |||
| final String match = m.group(); | |||
| final String arrayTypeStr = match.substring(6, match.length() - 1); | |||
There was a problem hiding this comment.
I think the right way to do this is to get group(1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new H2 version uses the standard SQL syntax for arrays (that is, qualified with the type of the array).
@mbudiu-vmw I addressed most issues, but two tests still fail. They both relate to a type-confusion on the return type of array_agg(). I couldn't immediately tell if it's to do with the jooq code or whether it's on the ddlog -> sql compiler side. Please have a look, otherwise I'll dig deeper later this week.
Signed-off-by: Lalith Suresh lsuresh@vmware.com