Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Instant Clone feature #1558

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

brian57860
Copy link
Contributor

Resolves: #1392

@vmwclabot
Copy link
Member

@brian57860, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brian57860 , this looks great. Are you able to sign the CLA?

@brian57860
Copy link
Contributor Author

Hello @dougm, I'm just waiting for legal to approve the CLA.

@brian57860
Copy link
Contributor Author

Hello @dougm still waiting on legal, I will resubmit the pull request if necessary when we obtain approval.

@dougm
Copy link
Member

dougm commented Aug 20, 2019

No need to resubmit @brian57860 , you can leave the pull request open.

@fehersanyi-bitrise
Copy link

Hello @dougm , Is there a chance that this will be merged soon?
also, great job implementing it @brian57860

@dougm
Copy link
Member

dougm commented Sep 7, 2019

@fehersanyi-bitrise we just need a CLA signed by @brian57860 . Let me know if I can help with anything there @brian57860

@brian57860
Copy link
Contributor Author

Sorry for the delay, but still waiting on legal!

@fehersanyi-bitrise
Copy link

Hello @brian57860!
Sorry to bother, but is there any progress with legal regarding this PR? 🤔

@brian57860
Copy link
Contributor Author

Hello @fehersanyi-bitrise
Please accept my apologies, I haven't forgotten this as I want it merged as much as you do.
We are still waiting on our legal department to make a decision on a suite of CLAs.

@fehersanyi-bitrise
Copy link

Thanks for the quick answer! We hope it will accepted soon! 🙃

@ghaabor
Copy link

ghaabor commented Jan 14, 2020

hey @brian57860, do you know about any progress regarding this?

@akutz
Copy link
Member

akutz commented Jun 11, 2020

Hi @brian57860,

Is there anything we can do to help you unblock this PR? If so, please let us know!

@BEPhipps BEPhipps force-pushed the feature/instantclone branch 3 times, most recently from bc89014 to afeb288 Compare July 29, 2020 10:37
@XenoPhex
Copy link

XenoPhex commented Oct 21, 2020

Any progress on getting this merged?

@brian57860 have you been able to get your legal department to sign the CLA?

@vmwclabot
Copy link
Member

@brian57860, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

@akutz
Copy link
Member

akutz commented Dec 1, 2020

@dougm CLA is approved, yay! Let's get this merged!

@vmwclabot
Copy link
Member

@brian57860, VMware has approved your signed contributor license agreement.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brian57860 🎉

@dougm dougm merged commit cad8518 into vmware:master Dec 2, 2020
@brian57860
Copy link
Contributor Author

Apologies for the delay @dougm but process was totally outside of my control.

@dougm
Copy link
Member

dougm commented Dec 2, 2020

Understood, no worries on the delay @brian57860 . Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can I use instant clone functionality with govmomi/govc?
7 participants