vcsim: avoid ViewManager.ModifyListView race

[dougm]

No description provided.

[mikekim]

lgtm.
I couldn't understand why this works and the other does not, though.

[dougm]

I'm not sure either. But Registry.WithLock is used to protect This by default when methods are invoked, such as the ListView instance when the ModifyListView method is invoked. The PropertyCollector also uses WithLock where appropriate. Registry has a [types.ManagedObjectReference]sync.Locker and the race this test produced was the read of mo.Reference.Reference(). I suppose the race detector may not know what happens behind that interface impl, unlike it does when we use the ListView.Self field directly. How we've avoided this problem with other objects, I don't know.

govmomi/simulator/registry.go

Line 524 in 0614f98

ref = obj.Reference()