Expose config-reloader prometheus metrics #147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when config-reloader fails to validate the fluentd configurations
for a given namespace, an error is logged and is attached to the namespace
via an annotation. This system, however, requires users to actively look
at namespace annotations or logs to ensure no errors are present whenever
a change in a fluentd configuration is deployed.
Users that are already utilizing Prometheus in their Kubernetes clusters,
are most likely measuring applications' stability via metrics and routing
alerts to a central location, where they are more visible.
This commit introduces the capability for config-reloader to expose its
own Prometheus metrics, which provide a simple boolean metric per
namespace exposing whether the fluentd configs in that namespace passed
validation or not.
These simple metrics allow users to define rules in Prometheus to alert
in case a namespace is throwing errors in fluentd configurations validation.
Such a rule can look something like
This commit also adds the possibility of configuring the port that the
config-reloader will be listening on to expose such metrics via a flag.
Furthermore it adds the necessary resources to the helm chart to ensure
that, if the
prometheusEnabled
value is set totrue
, the correspondingServices and, if enabled, ServiceMonitors are also created.