Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in values.yaml #205

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix typo in values.yaml #205

merged 1 commit into from
Apr 21, 2021

Conversation

Revellski
Copy link

Typo in values.yaml fluentdLog(L/l)evel causes reloader container to fail:

time="2021-04-21T16:11:02Z" level=info msg="Config: &{Master: KubeConfig: FluentdRPCPort:24444 TemplatesDir:/templates OutputDir:/fluentd/etc LogLevel:debug FluentdLogLevel: AnnotConfigmapName:logging.csp.vmware.com/fluentd-configmap AnnotStatus:logging.csp.vmware.com/fluentd-status DefaultConfigmapName:fluentd-config IntervalSeconds:45 Datasource:default CRDMigrationMode:false FsDatasourceDir: AllowFile:false ID:kfo-log-router FluentdValidateCommand:/usr/local/bundle/bin/fluentd -p /fluentd/plugins MetaKey: MetaValues: LabelSelector: KubeletRoot:/var/lib/kubelet Namespaces:[] PrometheusEnabled:false MetricsPort:9000 AllowTagExpansion:false AdminNamespace:kube-system level:0 ParsedMetaValues:map[] ParsedLabelSelector: ExecTimeoutSeconds:30}"
time="2021-04-21T16:11:02Z" level=fatal msg="Config validation failed: failed to parse fluentd log level: not a valid Fluentd log Level: \"\""
  reloader:                                                                                                                                   
    Container ID:  docker://ae2c058cc019a944ed6937141a882577d70435713549e46ff6c2a45a109b3a72                                                  
    Image:         vmware/kube-fluentd-operator:latest                                                                                        
    Image ID:      docker-pullable://vmware/kube-fluentd-operator@sha256:840e200fde52487e7543c002a8fb6261b8000230507e58468fb1a6906aed253b     
    Port:          <none>                                                                                                                     
    Host Port:     <none>                                                                                                                     
    Command:                                                                                                                                  
      /bin/config-reloader                                                                                                                    
      --datasource=default                                                                                                                    
      --default-configmap=fluentd-config                                                                                                      
      --interval=45                                                                                                                           
      --log-level=debug                                                                                                                                                                                                                                                                     
>>>      --fluentd-loglevel=                                                                                                                                                                                                                                                                   
      --output-dir=/fluentd/etc                                                                                                                                                                                                                                                             
...                 

@vmwclabot
Copy link
Member

@Revellski, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Iliyan Bobev <ibobev@vmware.com>
Copy link
Contributor

@Cryptophobia Cryptophobia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Cryptophobia
Copy link
Contributor

Looks like we made a mistake, changed it in one daemonset but forgot to change in values.yaml . Thank you @Revellski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants