unify harbor db and clair db password in first boot #1684
Conversation
| # Set MySQL and Clair DB passwords on first boot | ||
| configureHarborCfgOnce db_password "$(genPass)" | ||
| configureHarborCfgOnce clair_db_password "$(genPass)" | ||
| # Set Harbor DB and Clair DB passwords on first boot |
There was a problem hiding this comment.
What happens with an upgraded config? configureHarborCfgOnce would not overwrite an existing managed config line so if after migration the db_password or clair_db_password were tagged with the managed by line, lines 143-144 would have no effect.
There was a problem hiding this comment.
Looks like these lines are tagged after upgrade https://github.com/vmware/vic-product/blob/master/installer/build/scripts/upgrade/upgrade-harbor.sh#L126
There was a problem hiding this comment.
Is this behavior acceptable?
There was a problem hiding this comment.
@andrewtchin could I open anther PR to fix the upgrade issue later? It's because that we are still working on the implementation of DB migration script. It may take at least one sprint as the big change on Harbor DB in the next release.
There was a problem hiding this comment.
This PR could fix the harbor launch issue, and do not block vic CI.
(cherry picked from commit 49623c7)
(cherry picked from commit 49623c7)
(cherry picked from commit 49623c7)
As for Harbor DB migrates to pgsql, the clair DB needs to share the same password with harbor DB. This commit is to fix it in vic env.