Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique disk mount and fix manifest shasum #1726

Merged
1 commit merged into from May 9, 2018
Merged

Add unique disk mount and fix manifest shasum #1726

1 commit merged into from May 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 9, 2018

VIC Appliance Checklist:

  • Up to date with master branch
  • Added tests
  • Considered impact to upgrade
  • Tests passing
  • Updated documentation
  • Impact assessment checklist

If this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist

Fixes #1725. Also bumps the disk size available during the ova build.

@mdharamadas1 mdharamadas1 self-requested a review May 9, 2018 14:49
Copy link
Contributor

@mdharamadas1 mdharamadas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost ghost merged commit 7a3d847 into vmware:master May 9, 2018
@ghost ghost deleted the fix/build-issues branch May 9, 2018 18:12
zjs pushed a commit to zjs/vic-product that referenced this pull request Jun 20, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops 
during disk export. Fixes vmware#1725.
zjs pushed a commit to zjs/vic-product that referenced this pull request Jun 20, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops 
during disk export. Fixes vmware#1725.

(cherry picked from commit 7a3d847)
zjs pushed a commit to zjs/vic-product that referenced this pull request Jun 22, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops 
during disk export. Fixes vmware#1725.

(cherry picked from commit 7a3d847)
zjs pushed a commit to zjs/vic-product that referenced this pull request Jun 23, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops 
during disk export. Fixes vmware#1725.

(cherry picked from commit 7a3d847)
zjs pushed a commit to zjs/vic-product that referenced this pull request Jun 23, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops
during disk export. Fixes vmware#1725.

(cherry picked from commit 7a3d847)
zjs pushed a commit that referenced this pull request Jun 23, 2018
Slightly increases the disk size of the ova during the
installer build process. Fixes a syntax error during the
manifest generation and removes target disk loops
during disk export. Fixes #1725.

(cherry picked from commit 7a3d847)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants