-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique disk mount and fix manifest shasum #1726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdharamadas1
approved these changes
May 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ghost
deleted the
fix/build-issues
branch
May 9, 2018 18:12
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 20, 2018
Slightly increases the disk size of the ova during the installer build process. Fixes a syntax error during the manifest generation and removes target disk loops during disk export. Fixes vmware#1725.
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 20, 2018
Slightly increases the disk size of the ova during the installer build process. Fixes a syntax error during the manifest generation and removes target disk loops during disk export. Fixes vmware#1725. (cherry picked from commit 7a3d847)
6 tasks
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 22, 2018
Slightly increases the disk size of the ova during the installer build process. Fixes a syntax error during the manifest generation and removes target disk loops during disk export. Fixes vmware#1725. (cherry picked from commit 7a3d847)
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 23, 2018
Slightly increases the disk size of the ova during the installer build process. Fixes a syntax error during the manifest generation and removes target disk loops during disk export. Fixes vmware#1725. (cherry picked from commit 7a3d847)
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 23, 2018
Slightly increases the disk size of the ova during the installer build process. Fixes a syntax error during the manifest generation and removes target disk loops during disk export. Fixes vmware#1725. (cherry picked from commit 7a3d847)
zjs
pushed a commit
that referenced
this pull request
Jun 23, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIC Appliance Checklist:
master
branchIf this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist
Fixes #1725. Also bumps the disk size available during the ova build.