Remove erroneous backticks in linker flags #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing the tag command with an environment variable, the surrounding backticks were not removed. This was not caught during testing because the script did not return a non-zero exit code, even though an error had occurred. Add a set line to prevent similar errors from going undetected in the future.
hickeng
approved these changes
Jun 29, 2018
zjs
added a commit
to zjs/vic-product
that referenced
this pull request
Jun 29, 2018
When replacing the tag command with an environment variable, the surrounding backticks were not removed. This was not caught during testing because the script did not return a non-zero exit code, even though an error had occurred. Add a set line to prevent similar errors from going undetected in the future. (cherry picked from commit 658a408)
6 tasks
zjs
added a commit
that referenced
this pull request
Jun 29, 2018
When replacing the tag command with an environment variable, the surrounding backticks were not removed. This was not caught during testing because the script did not return a non-zero exit code, even though an error had occurred. Add a set line to prevent similar errors from going undetected in the future. (cherry picked from commit 658a408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replacing the tag command with an environment variable, the
surrounding backticks were not removed.
This was not caught during testing because the script did not return
a non-zero exit code, even though an error had occurred. Add a set
line to prevent similar errors from going undetected in the future.
VIC Appliance Checklist:
masterbranchIf this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist