Separate persistent disks #960
Conversation
ghost
changed the title
ghost
requested review from
|
|
||
| task "VMDK Sizes" | ||
| du -h bin/* | ||
| du -h bin/* |
There was a problem hiding this comment.
is this used to set the size in the ovf at the end? i think that's not happening correctly on master
There was a problem hiding this comment.
No, it just prints out the value. ovf vmdk file reference sizes are definitely not correct in master, and haven't been for a long time.
| @@ -38,7 +38,11 @@ for _, s in enumerate(dataMap["services"]): | |||
| dataMap["services"][s]["restart"] = "on-failure" | |||
| if "volumes" in dataMap["services"][s]: | |||
| for kvol, vol in enumerate(dataMap["services"][s]["volumes"]): | |||
| if vol.startswith( '/data' ): | |||
| if vol.startswith( '/data/database' ): | |||
There was a problem hiding this comment.
can you put a comment to note that this is fixing up the compose file?
| @@ -1,8 +1,8 @@ | |||
| [Unit] | |||
| Description=Demo VCH Installer Wizard Service | |||
| Documentation=https://github.com/vmware/vic | |||
| After=engine_installer_startup.service data.mount | |||
| Requires=data.mount | |||
| After=engine_installer_startup.service .targetvic-mounts.target | |||
|
reminder to ping stuart to update docs and system requirements for this |
|
Remove this since it's not needed for upgrade anymore https://github.com/vmware/vic-product/blob/master/installer/build/cache.sh#L31 |
|
Also if logs will be lost during the upgrade to new disks, print a warning in the upgrade script with a confirm y/n input |
| @@ -0,0 +1,44 @@ | |||
| #!/usr/bin/env bash | |||
Fixes #743, consistent with storage design proposals in #954.
Also includes a hot fix for failing fast in the cache script if a curl request returns an error.
Adds the
-itflag to building the docker container locally.