-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update container VM image size and bridge network signposts #179
Update container VM image size and bridge network signposts #179
Conversation
|
||
.bridge-network-signpost { | ||
min-width: 600px; | ||
max-width: 600px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary here to set min and max to the same? Can we not set the width only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the signpost is inside a col-xs-1, it is using the min-width which results in a thin and tall signpost popup due to the long text inside. Setting width to signpost max-width now.
@@ -56,7 +56,7 @@ | |||
<div class="col-xs-3"> | |||
|
|||
<label> | |||
Base image size | |||
Maximum Container VM image size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrapping to 2 lines and hampers readability. Checked with Louis and rather than adjusting layout he suggested to change the text to read "Max Container VM image size" to help it some.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing Maximum to Max, leaves the word "size" alone, in the second line. Adding a br, and a new line-height now, so it looks like the mockups.
* Update container VM image size and bridge network signposts * Fix image size label and bridge network signpost styles
Fixes #59
Fixes #60