Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container VM image size and bridge network signposts #179

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

cristianfalcone
Copy link
Contributor

Fixes #59
Fixes #60


.bridge-network-signpost {
min-width: 600px;
max-width: 600px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary here to set min and max to the same? Can we not set the width only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the signpost is inside a col-xs-1, it is using the min-width which results in a thin and tall signpost popup due to the long text inside. Setting width to signpost max-width now.

@@ -56,7 +56,7 @@
<div class="col-xs-3">

<label>
Base image size
Maximum Container VM image size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrapping to 2 lines and hampers readability. Checked with Louis and rather than adjusting layout he suggested to change the text to read "Max Container VM image size" to help it some.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@cristianfalcone cristianfalcone Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing Maximum to Max, leaves the word "size" alone, in the second line. Adding a br, and a new line-height now, so it looks like the mockups.

@jak-atx jak-atx merged commit fdd1abf into vmware:master Dec 4, 2017
jak-atx pushed a commit that referenced this pull request Dec 4, 2017
* Update container VM image size and bridge network signposts

* Fix image size label and bridge network signpost styles
jak-atx added a commit that referenced this pull request Dec 4, 2017
)

* Update container VM image size and bridge network signposts

* Fix image size label and bridge network signpost styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants