Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with networks population when host name contains some extra… #440

Merged
merged 1 commit into from
May 3, 2018

Conversation

javierfz1980
Copy link
Contributor

This commit will fix an error produced when hosts contains some extra text on the name added by the vc like '(reboot required)'

Fixes #423

PR acceptance checklist:

[ x ] All unit tests pass
[ x ] All e2e tests pass
[ n/a ] Unit test(s) included*
[ n/a ] e2e test(s) included*
[ n/a ] Screenshot attached and UX approved*

423-fix

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #440 into master will increase coverage by 0.39%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage    66.8%   67.19%   +0.39%     
==========================================
  Files          60       60              
  Lines        2711     2722      +11     
  Branches      477      477              
==========================================
+ Hits         1811     1829      +18     
+ Misses        612      605       -7     
  Partials      288      288
Impacted Files Coverage Δ
...ard/compute-capacity/compute-capacity.component.ts 87.09% <100%> (ø) ⬆️
...-vch-wizard/mocks/create-vch-wizard-mocked-data.ts 100% <100%> (ø) ⬆️
...app/create-vch-wizard/create-vch-wizard.service.ts 45.9% <68.42%> (+5.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b05ee3...d7a6f3f. Read the comment docs.

@javierfz1980 javierfz1980 self-assigned this Apr 20, 2018
… text

This commit will fix an error produced when hosts contains some extra text on the name added by the vc like '(reboot required)'
@jak-atx jak-atx merged commit 0f00fda into vmware:master May 3, 2018
javierfz1980 added a commit to javierfz1980/vic-ui that referenced this pull request May 18, 2018
… text (vmware#440)

This commit will fix an error produced when hosts contains some extra text on the name added by the vc like '(reboot required)'
javierfz1980 added a commit that referenced this pull request May 18, 2018
…ns some extra text (#440) (#484)

This commit will fix an error produced when hosts contains some extra text on the name added by the vc like '(reboot required)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Networks don't populate if no cluster is created
4 participants