Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom kernel_spec_manager class #1404

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

ClaytonAstrom
Copy link
Contributor

@ClaytonAstrom ClaytonAstrom commented Oct 3, 2023

References

Resolves #1403

Code changes

I've exposed the app level kernel_spec_manager property to the VoilaConfiguration. I've also allowed for the startup_timeout property to be set as well for async managers.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Binder 👈 Launch a Binder on branch ClaytonAstrom/voila/main

@trungleduc
Copy link
Member

Thank you for opening the PR, could you update the documentation for the new configurations?

@ClaytonAstrom
Copy link
Contributor Author

I've added documentation to the customize.md @trungleduc , let me know if there's other places I'm missing though

@trungleduc trungleduc added the enhancement New feature or request label Oct 3, 2023
@trungleduc
Copy link
Member

Thanks @ClaytonAstrom

@trungleduc trungleduc merged commit 9a8147a into voila-dashboards:main Oct 25, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for other kernel_spec_manager classes
2 participants