Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined name: from io import BytesIO for line 178 #228

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jun 12, 2019

flake8 testing of https://github.com/QuantStack/voila on Python 3.7.1

$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics

./setup.py:177:15: F821 undefined name 'BytesIO'
        buf = BytesIO()
              ^
1     F821 undefined name 'BytesIO'
1

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

@SylvainCorlay SylvainCorlay merged commit b5b386e into voila-dashboards:master Jun 13, 2019
@SylvainCorlay
Copy link
Member

Thanks @cclauss!

@cclauss cclauss deleted the patch-1 branch June 13, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants