New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stray tag in the lab template #774

Merged

maartenbreddels merged 1 commit into voila-dashboards:master from jtpio:stray-tag

Jan 11, 2021

Member

jtpio commented Dec 2, 2020

Noticed with the voila-gridstack template which is using lab as the base template: https://github.com/voila-dashboards/voila-gridstack/blob/23d747087aaff5007769074b7ac780c59595a71b/share/jupyter/nbconvert/templates/gridstack/conf.json#L1

Moving the voila_setup above to the body_footer block should place the script before the </body> closing tag:


          Fix stray tag in the lab template

811d4e8

jtpio force-pushed the stray-tag branch from c17fa27 to 811d4e8 Compare

January 8, 2021 09:21

Member Author

jtpio commented Jan 11, 2021

cc @maartenbreddels since if you are currently looking at an issue with the templates.

maartenbreddels merged commit 332b257 into voila-dashboards:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet