JariBakken: Don't try to unpack failed Gecko downloads.

r13222

rake-tasks/downloader.rb

@@ -2,6 +2,8 @@
 require "uri"
 
 class Downloader
+  class Error < StandardError; end
+
   CL_RESET = Platform.windows? ? '' : "\r\e[0K"
 
   def self.fetch(source_url, destination_path = nil)
@@ -25,7 +27,7 @@ def initialize(source, destination)
   end
 
   def download!
-    Net::HTTP.get_response(@url) do |response|
+    response = Net::HTTP.get_response(@url) do |response|
       total = response.content_length
       progress = 0
       segment_count = 0
@@ -43,6 +45,10 @@ def download!
       end
     end
 
+    unless response.kind_of? Net::HTTPSuccess
+      raise Error, "#{response.code} for #{@url}"
+    end
+
     complete_progress
   end
 
@@ -55,6 +61,6 @@ def report_progress(progress, total)
   end
 
   def complete_progress
-    print CL_RESET
+    puts CL_RESET
   end
 end

rake-tasks/gecko_sdks.rb

@@ -36,7 +36,7 @@ def define_rule(path, url)
         mv File.join(destination, "xulrunner-sdk"), path
       rescue StandardError, Timeout::Error => ex
         # ignore errors - dependant targets will fall back to prebuilts
-        $stderr.puts "Failed to download the Gecko 2 SDK - manually delete #{path} to retry."
+        $stderr.puts "Failed to download the Gecko 2 SDK - manually delete #{path} to retry. (#{ex.inspect})"
 
         next
       ensure