Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning when loading a model with another framework version #94

Closed
Tracked by #89
perdy opened this issue Mar 17, 2023 · 0 comments · Fixed by #89
Closed
Tracked by #89

Warning when loading a model with another framework version #94

perdy opened this issue Mar 17, 2023 · 0 comments · Fixed by #89
Assignees
@perdy
Labels
enhancement New feature or request
Milestone
1.3

Comments

@perdy
Copy link
Member

perdy commented Mar 17, 2023

The point when Flama is loading a FLM is a good chance to check if the framework used for previously serializing the model was on the same version as it is currently for running it.

In case it's being loaded with a different version of the framework a warning must be raised to let the users that they are doing something dangerous.
@perdy perdy added the enhancement New feature or request label Mar 17, 2023
@perdy perdy added this to the 1.3 milestone Mar 17, 2023
@perdy perdy self-assigned this Mar 17, 2023
@perdy perdy linked a pull request Mar 17, 2023 that will close this issue
1.3 #89
Merged
8 tasks
@perdy perdy mentioned this issue Mar 17, 2023
Merged
8 tasks
perdy added a commit that referenced this issue Mar 17, 2023
@perdy
✨ Warning loading a model with another framework version (#94)
55cc0e2
perdy added a commit that referenced this issue Mar 17, 2023
@perdy
✨ Warning loading a model with another framework version (#94)
318b461
@perdy perdy closed this as completed in #89 Mar 17, 2023
github-actions bot pushed a commit that referenced this issue Mar 17, 2023
@semantic-release-bot
🔖 1.3.0 [skip ci]
451ce8d 
# [v1.3.0](v1.2.0...v1.3.0) (2023-03-17)

## ✨ New Features
- [`d5715a7`](d5715a7)  Allow all endpoint responses in swagger schema (#88) (Issues: [`#88`](https://github.com/vortico/flama/issues/))
- [`21292dc`](21292dc)  Schema type as annotation for input and ouput schemas (#91) (Issues: [`#91`](https://github.com/vortico/flama/issues/))
- [`693fdf7`](693fdf7)  Script for fixing lint errors (#93) (Issues: [`#93`](https://github.com/vortico/flama/issues/))
- [`cbd026f`](cbd026f)  Allow to tag routes (#92) (Issues: [`#92`](https://github.com/vortico/flama/issues/))
- [`318b461`](318b461)  Warning loading a model with another framework version (#94) (Issues: [`#94`](https://github.com/vortico/flama/issues/))
- [`ac82633`](ac82633)  Include artifacts in model inspect (#95) (Issues: [`#95`](https://github.com/vortico/flama/issues/))
- [`056cd90`](056cd90)  CLI command to interact with an ML model without server (#96) (Issues: [`#96`](https://github.com/vortico/flama/issues/))

## 🐛 Bug Fixes
- [`18daa90`](18daa90)  Amend some Enum instantiations from strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perdy perdy

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

1.3 vortico/flama
1 participant
@perdy