Skip to content

Commit

Permalink
Add configuration variable for disabling frame filtering globally or …
Browse files Browse the repository at this point in the history
…on specific datasets (#4604)

* Add disable frame filtering dataset config value

* Add disable_frame_filtering option to global config

* Add disableFrameFiltering to sidebar

* Alphabetize docs table

* Update dataset app config disable frame filtering to be optional

* Update logic to check if dataset disable frame filtering is null

* Seperate disable path into checkbox and filter options + lint

* Remove usage of fully disabled paths in favor of disabled filter paths

* Fix samples container using wrong disable path filter

* Add e2e for disable-frame-filtering config value

* Remove dropdown arrow when field is disabled

* lint + update e2e tests to use different datasets to avoid conflicts

* Fix e2e test for lightning mode

* e2e python fix

* Fix e2e formatting

* linting

* documenting disable_frame_filtering

* Refactor AddIndex to support additional use cases

* Update e2e for frame filtering to expect icon

* Add frame filtering disabled tooltip

* Allow frame filtering in the modal

* Update python union usage to spread operator

* Remove disable arrow and update logic to show tooltip when disabled

* remove stray log

* linting, dataset default to None

* rm log, set bug fix

---------

Co-authored-by: brimoor <brimoor@umich.edu>
Co-authored-by: Benjamin Kane <ben@voxel51.com>
  • Loading branch information
3 people authored Aug 7, 2024
1 parent fdd03b5 commit 1da5dc8
Show file tree
Hide file tree
Showing 29 changed files with 644 additions and 336 deletions.
36 changes: 18 additions & 18 deletions app/packages/aggregations/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
{
"compilerOptions": {
"target": "ESNext",
"module": "ESNext",
"lib": ["ESNext", "DOM", "DOM.Iterable"],
"moduleResolution": "Node",
"sourceMap": true,
"resolveJsonModule": true,
"esModuleInterop": true,
"noEmit": false,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noImplicitAny": false,
"plugins": [],
"composite": true
},
"include": ["./src"],
"exclude": ["node_modules"]
"compilerOptions": {
"target": "ESNext",
"module": "ESNext",
"lib": ["ESNext", "DOM", "DOM.Iterable"],
"moduleResolution": "Node",
"sourceMap": true,
"resolveJsonModule": true,
"esModuleInterop": true,
"noEmit": false,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noImplicitAny": false,
"plugins": [],
"composite": true
},
"include": ["./src"],
"exclude": ["node_modules"]
}
27 changes: 17 additions & 10 deletions app/packages/app/src/pages/__generated__/IndexPageQuery.graphql.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 1da5dc8

Please sign in to comment.