add ExecutionOptions to execute_operator() #3850
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.0 #3850 +/- ##
===================================================
- Coverage 15.56% 15.56% -0.01%
===================================================
Files 729 729
Lines 80994 81365 +371
Branches 1075 1085 +10
===================================================
+ Hits 12609 12661 +52
- Misses 68385 68704 +319
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fiftyone/operators/operator.py
Outdated
| resolved_delegation = self.resolve_delegation(ctx) | ||
| if resolved_delegation is None: | ||
| # legacy behavior | ||
| if resolved_delegation is not None: |
There was a problem hiding this comment.
@ritch this is the key change: if resolve_delgation() != None, then we rely on it to set ExecutionOptions
|
|
||
| if params is None: | ||
| params = ctx.get("params", {}) | ||
| ctx = {**ctx, **kwargs} # don't modify input `ctx` in-place |
There was a problem hiding this comment.
@ritch this is the other key change: it allows for request_delegation and delegation_target to be correctly passed through to the ExecutionContext using either of these syntaxes:
foo.execute_operator(..., ctx={"request_delegation": True, ...})
foo.execute_operator(..., request_delegation=True)There was a problem hiding this comment.
Great - and I'm assuming this is backwards compatible. Doesn't appear to be but I would be surprised if you missed that.
There was a problem hiding this comment.
yep, backwards compatible 👍
Change log
request_delegationanddelegation_targettoexecute_operator()resolve_execution_options()andset_progress()methodsNote: if a user passes
request_delegation=Truebut the operator doesn't support delegated execution, it will log a warning and just execute immediately instead: