Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiftyone-db Pop OS support #4626

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Add fiftyone-db Pop OS support #4626

merged 1 commit into from
Aug 9, 2024

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Aug 6, 2024

What changes are proposed in this pull request?

Add fiftyone-db Pop OS support. Resolves #4605

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features
    • Added new MongoDB download links for multiple architectures and Ubuntu versions.
  • Improvements
    • Enhanced case-insensitivity for download identifier lookups.
  • Version Update
    • Package version updated from 1.1.4 to 1.1.5.

@benjaminpkane benjaminpkane added the release Release PRs label Aug 6, 2024
@benjaminpkane benjaminpkane requested a review from a team August 6, 2024 23:17
@benjaminpkane benjaminpkane self-assigned this Aug 6, 2024
Copy link
Contributor

coderabbitai bot commented Aug 6, 2024

Walkthrough

The recent updates to the setup.py file enhance MongoDB installation support for various Ubuntu architectures. New download options for MongoDB binaries have been added, improving compatibility across multiple Ubuntu versions. Additionally, the case sensitivity in identifier lookups has been addressed, ensuring more reliable function performance. The package version has been incremented to reflect these changes.

Changes

Files Change Summary
package/db/setup.py Added MongoDB downloads for multiple Ubuntu architectures and versions; modified identifier lookup for case insensitivity; incremented version from 1.1.4 to 1.1.5.

Assessment against linked issues

Objective Addressed Explanation
Define a database_uri in FiftyOneConfig to connect to MongoDB (e.g., #4605).
Ensure MongoDB can be installed successfully on Pop!_OS and other distributions (e.g., #4605).
Improve the installation process to handle variations in OS identifiers (e.g., #4427). Lack of clarity on identifier handling.

🐰 In the garden, I hop and play,
With MongoDB now here to stay!
Ubuntu's paths, oh what a treat,
Case insensitivity makes it neat.
With every version, we leap and bound,
FiftyOne's magic is now profound! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love pop os 🚀

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0f16eb3 and ef06799.

Files selected for processing (1)
  • package/db/setup.py (3 hunks)
Additional comments not posted (3)
package/db/setup.py (3)

68-89: LGTM! Pop!_OS support added correctly.

The entries for Pop!_OS in the LINUX_DOWNLOADS dictionary are consistent with other distributions and the URLs appear correct.


145-145: LGTM! Case-insensitive lookup implemented.

Changing the key to d["ID"].lower() ensures that the lookup in the LINUX_DOWNLOADS dictionary is case-insensitive, improving robustness.


168-168: LGTM! Version incremented to 1.1.5.

The version increment from "1.1.4" to "1.1.5" appropriately indicates a new release with the enhancements and fixes.

@benjaminpkane benjaminpkane merged commit e3aa760 into main Aug 9, 2024
24 of 25 checks passed
@benjaminpkane benjaminpkane deleted the chore/db-pop-os branch August 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants