-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fiftyone-db
Pop OS support
#4626
Conversation
WalkthroughThe recent updates to the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love pop os 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- package/db/setup.py (3 hunks)
Additional comments not posted (3)
package/db/setup.py (3)
68-89
: LGTM! Pop!_OS support added correctly.The entries for Pop!_OS in the
LINUX_DOWNLOADS
dictionary are consistent with other distributions and the URLs appear correct.
145-145
: LGTM! Case-insensitive lookup implemented.Changing the key to
d["ID"].lower()
ensures that the lookup in theLINUX_DOWNLOADS
dictionary is case-insensitive, improving robustness.
168-168
: LGTM! Version incremented to 1.1.5.The version increment from "1.1.4" to "1.1.5" appropriately indicates a new release with the enhancements and fixes.
What changes are proposed in this pull request?
Add
fiftyone-db
Pop OS support. Resolves #4605What areas of FiftyOne does this PR affect?
fiftyone
Python library changesSummary by CodeRabbit