Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YOLOv5DatasetImporter to support loading list of .txt #4742

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

imyhxy
Copy link
Contributor

@imyhxy imyhxy commented Aug 28, 2024

What changes are proposed in this pull request?

Currently, the YOLOv5DatasetImporter does not support loading a split contains list of .txt, e.g.:

...
val:
  - one.txt
  - two.txt
  - three.txt
...

And, I make it support.

How is this patch tested? If it is not, please explain why.

I have tested the following variants of YOLOv5 dataset:

  • Single folder as a split.
  • Single txt as a split.
  • Multiple folder as a split.
  • Multiple txt as a split.
  • Multiple mixed folder and txt as a split.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features
    • Improved handling of dataset paths, allowing for multiple split paths to be processed.
    • Enhanced flexibility in managing various input formats for image paths.
  • Bug Fixes
    • Streamlined control flow for evaluating image paths, ensuring consistent processing of all provided paths.
  • Refactor
    • Simplified and clarified the structure of the code for better maintainability and readability.

Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Walkthrough

The changes enhance the setup method in the fiftyone/utils/yolo.py file by improving the handling of dataset paths and split information. The implementation now accommodates multiple split paths and refactors the image path processing logic for consistency. The overall structure of the code is more streamlined, with clearer separation of concerns.

Changes

Files Change Summary
fiftyone/utils/yolo.py Modified the setup method to handle multiple split paths and refactored image path processing logic.

Poem

🐇 In the meadow where changes bloom,
A rabbit hops, dispelling gloom.
With paths now clear and splits in tow,
We dance with joy, our dataset's glow!
Hooray for code, so bright and neat,
In the world of YOLO, we hop to the beat! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@imyhxy imyhxy changed the title Update YOLOv5DatasetImporter to support list of txt Update YOLOv5DatasetImporter to support list of txt Aug 28, 2024
@imyhxy imyhxy changed the title Update YOLOv5DatasetImporter to support list of txt Update YOLOv5DatasetImporter to support loading list of .txt Aug 28, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e8ec301 and 14dfedf.

Files selected for processing (1)
  • fiftyone/utils/yolo.py (1 hunks)

fiftyone/utils/yolo.py Show resolved Hide resolved
@brimoor brimoor changed the base branch from develop to fix-yolov5-importer August 28, 2024 14:05
@brimoor brimoor changed the base branch from fix-yolov5-importer to develop August 28, 2024 14:06
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brimoor
Copy link
Contributor

brimoor commented Aug 28, 2024

FYI we already have tests that cover quite a few aspects of YOLOv5 import/export here:

def test_yolov5_dataset(self):

@imyhxy
Copy link
Contributor Author

imyhxy commented Aug 28, 2024

LGTM, thanks!

You're welcome. You guys built such a great library.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (8b225c4) to head (14dfedf).
Report is 747 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4742      +/-   ##
===========================================
- Coverage    99.27%   99.12%   -0.16%     
===========================================
  Files           47       49       +2     
  Lines        16212    16642     +430     
===========================================
+ Hits         16095    16496     +401     
- Misses         117      146      +29     
Flag Coverage Δ
python 99.12% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brimoor brimoor merged commit c9cfc05 into voxel51:develop Aug 28, 2024
11 of 13 checks passed
brimoor added a commit that referenced this pull request Aug 28, 2024
@imyhxy imyhxy deleted the fix-yolov5-importer branch September 14, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants