fix tagger e2e tests

[sashankaryal]

fix e2e

Summary by CodeRabbit

• New Features

  • Introduced a method to hide modal controls, enhancing UI element visibility management.

• Bug Fixes

  • Improved interaction flow in the modal tagger by adjusting the sequence of hover and click actions.

• Tests

  • Streamlined modal control management in tests, improving reliability and accuracy of visual assertions.

[coderabbitai]

Walkthrough

The changes involve modifications to the ModalTaggerPom and ModalPom classes, as well as updates to the tagger.spec.ts test suite. The toggleOpen method in modal-tagger.ts has been adjusted to change the order of operations related to hovering and clicking. A new asynchronous method hideControls has been added to ModalPom to manage the visibility of controls. The test suite now utilizes hideControls instead of simulating keyboard input, streamlining the interaction with the modal.

Changes

Files	Change Summary
e2e-pw/src/oss/poms/action-row/tagger/modal-tagger.ts	Modified the toggleOpen method to reposition the hover action after the click event.
e2e-pw/src/oss/poms/modal/index.ts	Added a new asynchronous method hideControls to manage the visibility of modal controls. Removed duplicate import.
e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts	Updated the test suite to call modal.hideControls() instead of simulating keyboard presses, enhancing modal control management.

Poem

In the land of code where rabbits play,
New features hop in, brightening the day.
With controls that hide and clicks that flow,
Our modal dances, putting on a show!
So here's to changes, both big and small,
A joyful leap for one and all! 🐇✨

Tip

New review model

We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.

---

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 18b6bd5 and 681aea0.

Files selected for processing (3)

• e2e-pw/src/oss/poms/action-row/tagger/modal-tagger.ts (1 hunks)
• e2e-pw/src/oss/poms/modal/index.ts (2 hunks)
• e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts (2 hunks)

Additional context used

Path-based instructions (3)

e2e-pw/src/oss/poms/action-row/tagger/modal-tagger.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

e2e-pw/src/oss/poms/modal/index.ts (1)

Pattern **/*.{ts,tsx}: Review the Typescript and React code for conformity with best practices in React, Recoil, Graphql, and Typescript. Highlight any deviations.

Additional comments not posted (4)

e2e-pw/src/oss/poms/action-row/tagger/modal-tagger.ts (1)

13-13: Verify the change in the order of operations.

The hover operation on the tagger-container element has been moved after the click operation on the action-tag-sample-labels element.

Please ensure that this change in the sequence of operations is intended and does not introduce any unexpected behavior in the user interface interaction flow.

e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts (2)

110-110: LGTM!

The change from simulating keyboard input to directly manipulating the modal's controls through the modal.hideControls() method is a good improvement. It enhances the clarity and reliability of the test by reducing dependencies on keyboard events and focusing on the modal's state management.

---

127-127: LGTM!

The reasoning for this change is the same as the previous one. It enhances the test's robustness by eliminating unnecessary interactions and focusing on the modal's state management.

e2e-pw/src/oss/poms/modal/index.ts (1)

89-100: LGTM!

The new hideControls method is a good addition to the ModalPom class. It enhances the functionality by providing a way to control the visibility of UI elements.

The use of a loop to repeatedly press the key until the opacity reaches zero ensures that the controls are fully hidden. Parsing the opacity as a float provides a reliable way to determine if the controls are hidden.

The code changes are approved.

[benjaminpkane]

LGTM

[benjaminpkane]

Thanks for adding this 🙇