Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fix for Numerical Field in Summary Field Operator #4864

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

minhtuev
Copy link
Contributor

@minhtuev minhtuev commented Sep 27, 2024

What changes are proposed in this pull request?

Currently, when the field is numerical (such as the frame's confidence), the summary field operator errored out. This small bug fix rectifies that error.

image

How is this patch tested? If it is not, please explain why.

  • Manual test (✅ )

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • New Features

    • Updated the autocomplete view in the group selection to display the group itself instead of its name, enhancing clarity for users.
  • Bug Fixes

    • Improved the representation of choices in the group_by_selector for better user experience.

Copy link
Contributor

coderabbitai bot commented Sep 27, 2024

Walkthrough

The changes in this pull request focus on modifying the _create_summary_field_inputs function within the fiftyone/operators/builtin.py file. The key alteration involves how choices are added to the group_by_selector, shifting from using group.name to using group directly. This change affects the representation of choices in the autocomplete view, ensuring that the label corresponds to the group itself.

Changes

File Path Change Summary
fiftyone/operators/builtin.py Updated the _create_summary_field_inputs function to use group directly for choices in group_by_selector instead of group.name.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • ritch

Poem

In the code where choices bloom,
A rabbit hops to clear the gloom.
With groups now shining bright and clear,
Autocomplete will bring us cheer!
Hooray for changes, swift and neat,
A leap of joy, oh what a feat! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cb040ed and a38596d.

📒 Files selected for processing (1)
  • fiftyone/operators/builtin.py (1 hunks)
🔇 Additional comments (2)
fiftyone/operators/builtin.py (2)

1257-1258: LGTM: Minor change in CreateSummaryField.execute method

The change in the execute method of the CreateSummaryField operator is minimal and doesn't affect the overall functionality. The modification only alters how the group_by parameter is handled, which is consistent with the changes in the _create_summary_field_inputs function.


1258-1258: Verify the impact of changing group_by_selector choices

The modification in how choices are added to the group_by_selector could potentially change the behavior of the function. Previously, group.name was used, but now group is used directly. This change might affect how the choices are presented in the user interface and how they are processed later.

Please verify that:

  1. The group variable is always a string or has an appropriate string representation.
  2. This change is intentional and aligns with the expected behavior of the group_by functionality.
  3. Any downstream code that processes these choices is compatible with this change.

To help verify this change, you can run the following script to check the types of values being used as choices:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@minhtuev minhtuev requested review from brimoor and a team September 27, 2024 23:59
@brimoor brimoor changed the base branch from develop to release/v1.0.0 September 28, 2024 14:07
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! 🙇

@brimoor brimoor merged commit 543ecf3 into release/v1.0.0 Sep 28, 2024
13 checks passed
@brimoor brimoor deleted the bugfix/summary_field_operator branch September 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants