Performance bug: unnecessary double-decryption of blocks #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does look like a copy and paste error - mine by all accounts. Good spot @peculater. 👍 |
…to duplicate-block-decrypt
|
Rebased this against master now that the test-passing stuff is in. Yay for green checks. :-) |
Closed
|
Should this be closed? |
|
You mean merged, @mattkenn4545 ? If so then I am +1 for it. |
vinzent
approved these changes
Dec 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line is duplicated with no side-effect I can find. The comparable chunk dealing with string decrypting only has one call, as do both encryption chunks. Looks like a copy-and-paste-o. Removing it passes all tests (including puppet ones after PR #181) and gives me about a ~15% improvement in overall block decryption speed with the particular eyaml file I care about.