Puppet 7: Ensure we test against 7.24 or newer #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will run CI on PRs and merges to master. Also we define a dummy job which we can enforce during reviews.
main got moved to puppet 8 which now requires Ruby 3.1 or newer.
There was a fuckup with concurrent-ruby 1.2.0 release which dropped a private API that puppet used. newer Puppet versions (7.22 and newer) depend on concurrent-ruby < 1.2.0. We need to force ~> puppet 7.22 installation to ensure bundler doesn't pull in a newer concurrent-ruby and older Puppet version.
|
also contains:
|
sebastianrakel
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a fuckup with concurrent-ruby 1.2.0 release which dropped a
private API that puppet used. newer Puppet versions (7.22 and newer)
depend on concurrent-ruby < 1.2.0. We need to force ~> puppet 7.22
installation to ensure bundler doesn't pull in a newer concurrent-ruby
and older Puppet version.