Add support for EL8 #247
Add support for EL8 #247
Conversation
trevor-vaughan
force-pushed
the
add-el8-support
branch
from
27bc7d1
to
2b58d88
Compare
trevor-vaughan
force-pushed
the
add-el8-support
branch
from
2b58d88
to
7b3371a
Compare
|
Tests are failing due to ruby style. Suggest fixing those or adding the rubocop rules to be ignored and then this can be merged. |
trevor-vaughan
force-pushed
the
add-el8-support
branch
from
7b3371a
to
cf06b95
Compare
| @@ -531,8 +531,28 @@ firewalld::direct_passthroughs: | |||
| * `args`: Name of the passthroughhrough to add (e.g: -A OUTPUT -j OUTPUT_filter) | |||
|
|
|||
|
|
|||
| ## Testing | |||
There was a problem hiding this comment.
We've got our contributing guidelines which explain how to execute tests: https://github.com/voxpupuli/puppet-firewalld/blob/master/.github/CONTRIBUTING.md
That file is managed by modulesync: https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.github/CONTRIBUTING.md.erb
Could you link to that file / update it instead of duplicating the information?
There was a problem hiding this comment.
@bastelfreak The point here is that these tests have to be run in vagrant and not docker like we might otherwise.
There was a problem hiding this comment.
Can't test underlying firewalls properly in Docker-land
| @@ -1,6 +1,19 @@ | |||
| HOSTS: | |||
There was a problem hiding this comment.
We usually purge this file within modulesync and create nodesets on demand with https://github.com/puppetlabs/beaker-hostgenerator
There was a problem hiding this comment.
@bastelfreak The tests are going to quickly get more complicated than this will handle so I'd rather not right now.
There was a problem hiding this comment.
To clarify, these will be multi-node in the near future. Via work on simp-iptables, we have found that this is the only way that you can properly uncover bugs in the underlying system.
trevor-vaughan
force-pushed
the
add-el8-support
branch
4 times, most recently
from
2a36225
to
b12c808
Compare
|
Dear @trevor-vaughan, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
* Added OEL to the metadata.json * Added a very basic acceptance test to test the main components of the module. This should be expanded into multi-node tests later. * Added a REFERENCE.md * Updated the README.md to point to the REFERENCE.md and added instructions on how to run the acceptance test. Closes voxpupuli#246
trevor-vaughan
force-pushed
the
add-el8-support
branch
from
b12c808
to
7d63181
Compare
Pull Request (PR) description
module. This should be expanded into multi-node tests later.
instructions on how to run the acceptance test.
This Pull Request (PR) fixes the following issues
Fixes #246