Support specifying priority on rich rules

[ananace]

Pull Request (PR) description

Adds support for the priority option on rich rules, to allow ordering them outside of the normally implicit - and not guaranteed to be deterministic - ordering imposed by when they're added.

[decibelhertz]

Hi -- will this PR get rolled into a release? Been almost 2 years, but I cannot really convert from firewall to firewalld without the ability to set a priority in rich rules...

[tskirvin]

What's the word about getting this approved and implemented?

[bastelfreak]

@tskirvin there's an open comment from @trevor-vaughan that needs to be addressed :)

[tskirvin]

Fair enough, but I'm with @decibelhertz here - I can't really start converting from firewall to firewalld until this is addressed, and I'd prefer to work under the don't-let-perfect-be-the-enemy-of-good policy.

[ananace]

There we go, must've missed the notification about that comment.

Also rebased it onto master while I was at it adding a validation.

[tskirvin]

What's the word about getting a new puppet forge release for this change and any others that have come recently? The last official release I see was 4.5.1 back on 15 Aug.

[hex-m]

From what I get this feature is not available in the firewalld version that comes with centOS/rhel 7. So releasing this means the module does not support that OS-version anymore.

[brgerig]

I also find myself needing this enhancement. I thought I might be able to use it by pointing the Puppetfile mod at the github master branch instead of puppetforge, and it does appear that I'm getting code with these changes, but I'm still getting a Server Error: no parameter named 'priority' when I try to add a priority to a rich rule. Should it work as-is, or am I missing something?