Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload keepalived on refresh instead of restart #52

Closed
vincentbernat opened this issue Nov 14, 2014 · 6 comments
Closed

Reload keepalived on refresh instead of restart #52

vincentbernat opened this issue Nov 14, 2014 · 6 comments
Labels
enhancement New feature or request

Comments

@vincentbernat
Copy link
Contributor

Restarting keepalived can be a bit disruptive. For the VRRP part, all IP are removed and added back. For the IPVS part, all rules are removed than added back. When using reload instead, Keepalived tries to be smart and only add/remove the IP that need to be added/removed. The same for IPVS. Therefore, it is better to use reload if possible.

@arioch
Copy link
Contributor

arioch commented Nov 14, 2014

That's a valid point you have there.
I'll add a parameter to override it.

@arioch
Copy link
Contributor

arioch commented Nov 14, 2014

Here you go: 72ae45e.

I've added the following to README.md:

Soft-restart the Keepalived daemon

class { '::keepalived':
  service_restart => 'service keepalived reload',     # When using SysV Init
  # service_restart => 'systemctl reload keepalived', # When using SystemD
}

@arioch arioch added the enhancement New feature or request label Nov 14, 2014
vincentbernat added a commit to vincentbernat/puppet-keepalived that referenced this issue Nov 14, 2014
Reloading generaly doesn't impact existing VIP and VS while restarting
has a major impact. By default, reload instead of restarting.

Closes: voxpupuli#52
@vincentbernat
Copy link
Contributor Author

Oh, we did the same thing at the same moment. I should have told you. Well, ignore my PR then.

@arioch
Copy link
Contributor

arioch commented Nov 14, 2014

Ah, bummer!
I was waiting for a build to finish so I had a few minutes to spare. :)

@vincentbernat
Copy link
Contributor Author

I just tested your version, it works fine for me.

@arioch
Copy link
Contributor

arioch commented Nov 14, 2014

Excellent. Glad to hear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants